nicusX commented on a change in pull request #12591:
URL: https://github.com/apache/flink/pull/12591#discussion_r438559736



##########
File path: 
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSerializer.java
##########
@@ -170,7 +170,11 @@ public int getLength() {
 
        @Override
        public T createInstance() {
-               return InstantiationUtil.instantiate(type);
+               if (!isGenericRecord(type)) {

Review comment:
       Absolutely! This also remove any use of InstantiationUtil that does not 
seem to have any support for any AVRO idiosyncrasy




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to