nicusX commented on a change in pull request #12591:
URL: https://github.com/apache/flink/pull/12591#discussion_r438567233
##########
File path:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSerializer.java
##########
@@ -170,7 +170,11 @@ public int getLength() {
@Override
public T createInstance() {
- return InstantiationUtil.instantiate(type);
+ if (!isGenericRecord(type)) {
Review comment:
Not it's more consistent with other methods but still using
`InstantiationUtil.instantiate()` for specific records. They are concrete and
have default constructor, so it should be ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
