Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1568#discussion_r51427090
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/GroupReduceOperator.java
---
@@ -156,8 +162,8 @@ public boolean isCombinable() {
public GroupReduceOperator<IN, OUT> setCombinable(boolean combinable) {
// sanity check that the function is a subclass of the combine
interface
- if (combinable && !(function instanceof GroupCombineFunction)) {
- throw new IllegalArgumentException("The function does
not implement the combine interface.");
+ if (combinable && !(function instanceof GroupCombineFunction ||
function instanceof CombineFunction)) {
--- End diff --
If we change the `checkCombinability` method to return a boolean instead of
setting `this.combinable` directly, we can also use it here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
