Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1568#discussion_r51427575
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/GroupReduceOperator.java
---
@@ -193,7 +199,11 @@ public SingleInputSemanticProperties
getSemanticProperties() {
protected GroupReduceOperatorBase<?, OUT, ?>
translateToDataFlow(Operator<IN> input) {
String name = getName() != null ? getName() : "GroupReduce at "
+ defaultName;
-
+
+ this.function = (function instanceof CombineFunction) ?
+ new CombineToGroupCombineWrapper((CombineFunction)
function) :
--- End diff --
This does also add a bit of overhead to the `reduce` method because it is
wrapped. However, this should be OK since it is called just once per group.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
