tillrohrmann commented on a change in pull request #12278:
URL: https://github.com/apache/flink/pull/12278#discussion_r438843898
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolImpl.java
##########
@@ -648,26 +648,8 @@ boolean offerSlot(
slotOffer.getResourceProfile(),
taskManagerGateway);
- // check whether we have request waiting for this slot
- PendingRequest pendingRequest =
pendingRequests.removeKeyB(allocationID);
Review comment:
I think it should be fine to remap `SlotRequestIds` and `AllocationIds`.
In the end it is an implementation detail of the `SlotPoolImpl` how a
`SlotRequestId` is mapped to an `AllocationId` and no user of the `SlotPool`
should rely on/use it. The only important bit is to assign the orphaned
`AllocationId` so that we can react to signals from the `ResourceManager`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
