Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51453894
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/operator/DataSinkTest.java
---
@@ -311,7 +311,7 @@ public void testPojoSingleOrderFull() {
.sortLocalOutput("*", Order.ASCENDING);
}
- @Test(expected = InvalidProgramException.class)
+ @Test
public void testArrayOrderFull() {
--- End diff --
That is not how you fix a test. When the behaviour of the program changes,
then one should also adapt the test accordingly. E.g. checking that the order
of the elements is correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
