Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1566#issuecomment-178097783
  
    Thanks for your contribution @sbcd90. I think the PR needs still a bit of 
work before it can be merged. The implementation of `GenericArrayComparator` 
only works for primitive types. Furthermore, I think that it is easier to 
construct the comparator out of the component type information of the 
`ObjectArrayTypeInfo` instead of doing the type analysis again every time you 
call `compare`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to