[ 
https://issues.apache.org/jira/browse/FLINK-17752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134326#comment-17134326
 ] 

Jark Wu commented on FLINK-17752:
---------------------------------

Hi [~dwysakowicz], your proposal sounds good to me. Especially the separated 
configurable formats will make the format standard more comprehensible.

I have some thoughts about this:

1. If we allow the custom format, that would mean we allow to convert data with 
time zone information into a type without time zone. This may conflict with 
[~twalthr]'s point. I think this is powerful, but may still confuse users how 
the behavior is, for example, {{timestamp-format.without-time-zone=<millis 
since epoch>}} how the millis converted into TIMESTAMP? Will the millis be 
converted with +/- local time zone offset or a compile check exception be 
thrown? 
2. Do we allow to override {{timestamp-format.without-time-zone}} if 
{{timestamp.format.standard}} is not "custom"? If allow, do we still need the 
kind of "custom"? 



> Align the timestamp format with Flink SQL types in JSON format
> --------------------------------------------------------------
>
>                 Key: FLINK-17752
>                 URL: https://issues.apache.org/jira/browse/FLINK-17752
>             Project: Flink
>          Issue Type: Bug
>          Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile), Table 
> SQL / Ecosystem
>            Reporter: Jark Wu
>            Assignee: Shengkai Fang
>            Priority: Critical
>             Fix For: 1.11.0
>
>
> Currently, we are using RFC3339_TIMESTAMP_FORMAT (which will add timezone at 
> the end of string) to as the timestamp format in JSON. However, the string 
> representation fo {{TIMESTAMP (WITHOUT TIME ZONE)}} shoudn't adding 'Z' at 
> the end. 
> Other discussions: 
> [1]: 
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/TIME-TIMESTAMP-parse-in-Flink-TABLE-SQL-API-td33061.html
> [2]: 
> http://apache-flink.147419.n8.nabble.com/json-timestamp-json-flink-sql-td1914.html
> [3]: http://apache-flink.147419.n8.nabble.com/FLINK-SQL-td2074.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to