rmetzger commented on a change in pull request #12622:
URL: https://github.com/apache/flink/pull/12622#discussion_r440014828
##########
File path: flink-formats/flink-sql-orc/pom.xml
##########
@@ -0,0 +1,92 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
> But for accurate notice files it is necessary to be able to supply
each artifact with distinct NOTICE files, we need create a separate module.
But we would only need one NOTICE file in `flink-orc` which we will use for
the shaded fat jar. For the regular `flink-orc.jar` we don't need a special
NOTICE file, as it contains only Flink binaries.
Sorry that I'm making this so complicated. I'm just trying to make sure that
we are not introducing unnecessary complexity here, and that the NOTICE files
are valid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
