JingsongLi commented on a change in pull request #12622:
URL: https://github.com/apache/flink/pull/12622#discussion_r440029151
##########
File path: flink-formats/flink-sql-orc/pom.xml
##########
@@ -0,0 +1,92 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
> Sorry that I'm making this so complicated.
It's all right, your review makes things clearer~
I thought the meaning of https://github.com/apache/flink/pull/7251 is:
For the regular `flink-orc.jar` should has a `NOTICE` file too.
If we create a `flink-sql-orc` in `flink-orc` module with classifier
`sql-jar`. Then, there are two jars in artifact `flink-orc`.
And they should have different `NOTICE` files (Which is hard to do). One has
many dependencies, but another just is an simple file like:
```
// ------------------------------------------------------------------
// NOTICE file corresponding to the section 4d of The Apache License,
// Version 2.0, in this case for Apache Flink
// ------------------------------------------------------------------
Apache Flink
Copyright 2006-2020 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
flink-orc
Copyright 2014-2020 The Apache Software Foundation
```
Correct me if I wrong.
CC: @zentol
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
