twalthr commented on a change in pull request #12606:
URL: https://github.com/apache/flink/pull/12606#discussion_r440202517
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/data/conversion/DataStructureConverters.java
##########
@@ -149,6 +147,10 @@
switch (logicalType.getTypeRoot()) {
case ARRAY:
return
ArrayObjectArrayConverter.create(dataType);
+ case MULTISET:
Review comment:
According to the definition of `MapType` and `MultisetType`. We also
allow subclasses of `Map` such as `HashMap` or `LinkedHashMap` as input
parameters.
```
putConverter(LogicalTypeRoot.MAP, Map.class,
MapMapConverter::createForMapType);
```
... was too strict because it only matches if the class is `Map.class`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
