pnowojski commented on pull request #11541: URL: https://github.com/apache/flink/pull/11541#issuecomment-644162219
Can you explain what was the deadlock scenario? I haven't got time to fully analyse your solution, but `ConcurrentMap<...> clients` is being used in other methods and also even in the same method where you added `synchronized (connectionId)`, but before the synchornized section, so we can not simply change it to `HashMap`. Moreover your synchornized section wouldn't prevent two different `ConnectionID` requests from modifying `clients`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
