becketqin opened a new pull request #12676:
URL: https://github.com/apache/flink/pull/12676


   ## What is the purpose of the change
   The ExecutorNotifierTest#testExceptionInHandler() fails intermittently 
because the UncaughtExceptionHandler may fire after the ExecutorService has  
shutdown. The fix is to ensure only check the exception after the 
UncaughtExceptionHandler has fired.
   
   ## Brief change log
   918a6d4772d5db916a418daeb06cdbf0eb1bebf3 Wait on a `CountDownLatch` to 
ensure the `UncaughtExceptionHandler` has fired.
   
   ## Verifying this change
   Ran `ExecutorNotifierTest#testExceptionInHandler` in a loop for 10K+ times 
and did not see failure anymore. Without the patch, the test will fail in less 
than 500 runs.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to