Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1574#issuecomment-179138377
Looks good to me, but @gumchum's comment is valid.
One more thing, I would call the method on the Scala DataStream `def
javaStream : JavaStream[T] = stream`. I think that is more in line with the
Scala style: no parenthesis, because it is a simple accessor, and no "get"
prefix, because for methods that appear like variables (no parenthesis), that
seems the way they encourage it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
