azagrebin commented on a change in pull request #12278:
URL: https://github.com/apache/flink/pull/12278#discussion_r441577695



##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolPendingRequestFailureTest.java
##########
@@ -99,6 +105,40 @@ public void testFailingAllocationFailsPendingSlotRequests() 
throws Exception {
                }
        }
 
+       @Test
+       public void testFailingAllocationFailsRemappedPendingSlotRequests() 
throws Exception {
+               final List<AllocationID> allocations = new ArrayList<>();
+               resourceManagerGateway.setRequestSlotConsumer(slotRequest -> 
allocations.add(slotRequest.getAllocationId()));
+
+               try (SlotPoolImpl slotPool = setUpSlotPool()) {

Review comment:
       sure, I agree that  we can do the overall test cleanup as a separate 
issue if it is too much for this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to