rmetzger commented on a change in pull request #12687: URL: https://github.com/apache/flink/pull/12687#discussion_r441748810
########## File path: flink-connectors/flink-sql-connector-hbase/src/main/resources/META-INF/NOTICE ########## @@ -0,0 +1,60 @@ +flink-sql-connector-hbase +Copyright 2014-2020 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- commons-codec:commons-codec:1.10 +- commons-configuration:commons-configuration:1.7 +- commons-lang:commons-lang:2.6 +- commons-logging:commons-logging:1.1.1 Review comment: This dependency does not seem to be included in the jar (according to my maven shade plugin output) ########## File path: flink-connectors/flink-sql-connector-hbase/src/main/resources/META-INF/NOTICE ########## @@ -0,0 +1,27 @@ +flink-sql-connector-hbase +Copyright 2014-2020 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- commons-codec:commons-codec:1.10 +- commons-configuration:commons-configuration:1.7 +- commons-lang:commons-lang:2.6 +- commons-logging:commons-logging:1.1.3 +- com.google.guava:guava:12.0.1 +- com.yammer.metrics:metrics-core:2.2.0 +- io.netty:netty-all:4.1.44.Final +- org.apache.hbase:hbase-common:1.4.3 +- org.apache.hbase:hbase-protocol:1.4.3 +- org.apache.hbase:hbase-procedure:1.4.3 +- org.apache.hbase:hbase-client:1.4.3 +- org.apache.hbase:hbase-prefix-tree:1.4.3 +- org.apache.htrace:htrace-core:3.1.0-incubating Review comment: Maybe we should separate these dependencies in the list of dependencies, otherwise, people will be confused where the dependencies are coming from ########## File path: flink-connectors/flink-sql-connector-hbase/src/main/resources/META-INF/NOTICE ########## @@ -0,0 +1,27 @@ +flink-sql-connector-hbase +Copyright 2014-2020 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- commons-codec:commons-codec:1.10 +- commons-configuration:commons-configuration:1.7 +- commons-lang:commons-lang:2.6 +- commons-logging:commons-logging:1.1.3 +- com.google.guava:guava:12.0.1 +- com.yammer.metrics:metrics-core:2.2.0 +- io.netty:netty-all:4.1.44.Final Review comment: I believe we don't need to "expand" the dependencies included in "netty-all". Everything that is included in netty-all is licensed to the netty project (as long as there's nothing shaded etc.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
