leonardBang commented on a change in pull request #12687: URL: https://github.com/apache/flink/pull/12687#discussion_r441941620
########## File path: flink-connectors/flink-sql-connector-hbase/src/main/resources/META-INF/NOTICE ########## @@ -0,0 +1,60 @@ +flink-sql-connector-hbase +Copyright 2014-2020 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- commons-codec:commons-codec:1.10 +- commons-configuration:commons-configuration:1.7 +- commons-lang:commons-lang:2.6 +- commons-logging:commons-logging:1.1.1 Review comment: maven shade plugin output may miss them? These dependencies ``` com.fasterxml.jackson.core:jackson-annotations:2.4.0 com.fasterxml.jackson.core:jackson-core:2.4.0 com.fasterxml.jackson.core:jackson-databind:2.4.0 commons-logging:commons-logging:1.1.1 ``` has been shaded in `htrace-core`, I found the dependencies version in maven shade plugin output are different with these dependencies in `META-INF/DEPENDENCIES` of `htrace-core-3.1.0-incubating.jar` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
