curcur commented on a change in pull request #12525:
URL: https://github.com/apache/flink/pull/12525#discussion_r441942070
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
##########
@@ -207,9 +207,12 @@ public void testCleanUpExceptionSuppressing() throws
Exception {
testHarness.waitForTaskCompletion();
}
catch (Exception ex) {
- if (!ExceptionUtils.findThrowable(ex,
ExpectedTestException.class).isPresent()) {
- throw ex;
- }
+ Assert.assertTrue(ex.getCause() instanceof
ExpectedTestException);
+ Assert.assertTrue(
Review comment:
If you replace the 'assertTrue' with 'assertEquals' as suggested by IDE,
it will then ask to simplify the code.
I think 'assertTrue' is better than 'assertEquals' since we can achieve the
same purpose with shorter code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
