curcur commented on a change in pull request #12525:
URL: https://github.com/apache/flink/pull/12525#discussion_r442080801
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
##########
@@ -207,9 +207,12 @@ public void testCleanUpExceptionSuppressing() throws
Exception {
testHarness.waitForTaskCompletion();
}
catch (Exception ex) {
- if (!ExceptionUtils.findThrowable(ex,
ExpectedTestException.class).isPresent()) {
- throw ex;
- }
+ Assert.assertTrue(ex.getCause() instanceof
ExpectedTestException);
+ Assert.assertTrue(
Review comment:
I mean
`Assert.assertTrue(ex.getCause() instanceof ExpectedTestException)`; vs.
`Assert.assertEquals(True, ex.getCause() instanceof ExpectedTestException)`;
I clicked the little yellow blob on the left top, and that is what the IDE
suggesting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
