rkhachatryan opened a new pull request #12746:
URL: https://github.com/apache/flink/pull/12746
## What is the purpose of the change
This PR implements retries for connection to the upstream.
It contains changes from #11541 and fixes the issue of blocking the whole
`ConcurrentHashMap` by computing the value in `Future`.
It further simplifies the code and fixes some minor issues.
**Merging**
I think the three first commits should be squashed together.
## Brief change log
Original PR:
1. Add task manager netty client retry mechenism
2. use computeIfAbsent for exclusively building a new channel
Fix:
3. Don't block the whole NettyPartitionRequestClientFactory while connecting
Optional changes:
4. Remove NettyPartitionRequestClientFactory.ConnectingChannel
5. Simplify loop in
NettyPartitionRequestClientFactory.createPartitionRequestClient
6. Fix logging NettyPartitionRequestClientFactory
7. Remove ignored test
## Verifying this change
Added unit tests in `PartitionRequestClientFactoryTest`:
`testNettyClientConnectRetry`, `testNettyClientConnectRetryMultipleThread`,
`testNettyClientConnectRetryFailure`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
