[
https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15133886#comment-15133886
]
ASF GitHub Bot commented on FLINK-3234:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1585#discussion_r51992647
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/SortPartitionOperator.java
---
@@ -79,16 +112,33 @@ public SortPartitionOperator(DataSet<T> dataSet,
String sortField, Order sortOrd
* local partition sorting of the DataSet.
*
* @param field The field expression referring to the field of the
additional sort order of
- * the local partition sorting.
- * @param order The order of the additional sort order of the local
partition sorting.
+ * the local partition sorting.
+ * @param order The order of the additional sort order of the local
partition sorting.
* @return The DataSet with sorted local partitions.
*/
public SortPartitionOperator<T> sortPartition(String field, Order
order) {
+ if (useKeySelector) {
+ throw new InvalidProgramException("Expression keys
cannot be appended after selector function keys");
+ }
+
int[] flatOrderKeys = getFlatFields(field);
this.appendSorting(flatOrderKeys, order);
return this;
}
+ /**
+ * Appends an additional sort order with the specified field in the
specified order to the
+ * local partition sorting of the DataSet.
+ *
+ * @param keyExtractor The KeySelector function which extracts the key
value of the additional
+ * sort order of the local partition sorting.
+ * @param order The order of the additional sort order of the
local partition sorting.
+ * @return The DataSet with sorted local partitions.
+ */
+ public <K> SortPartitionOperator<T> sortPartition(KeySelector<T, K>
keyExtractor, Order order) {
--- End diff --
If you remove this method, it cannot be called ;-)
> SortPartition does not support KeySelectorFunctions
> ---------------------------------------------------
>
> Key: FLINK-3234
> URL: https://issues.apache.org/jira/browse/FLINK-3234
> Project: Flink
> Issue Type: Improvement
> Components: DataSet API
> Affects Versions: 1.0.0, 0.10.1
> Reporter: Fabian Hueske
> Assignee: Chiwan Park
> Fix For: 1.0.0
>
>
> The following is not supported by the DataSet API:
> {code}
> DataSet<MyObject> data = ...
> DataSet<MyObject> data.sortPartition(
> new KeySelector<MyObject, Long>() {
> public Long getKey(MyObject v) {
> ...
> }
> },
> Order.ASCENDING);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
