[ 
https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138573#comment-15138573
 ] 

ASF GitHub Bot commented on FLINK-3234:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1585#discussion_r52281965
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java 
---
    @@ -1377,6 +1377,24 @@ public long count() throws Exception {
                return new SortPartitionOperator<>(this, field, order, 
Utils.getCallLocationName());
        }
     
    +   /**
    +    * Locally sorts the partitions of the DataSet on the an extracted key 
in the specified order.
    +    * DataSet can be sorted on multiple values by returning a tuple from 
the KeySelector.
    +    *
    +    * Note that any key extraction methods cannot be chained with the 
KeySelector. To sort the
    --- End diff --
    
    "Note that any key extraction methods cannot be ..." -> "Note that no 
additional sort keys can be appended to a KeySelector."


> SortPartition does not support KeySelectorFunctions
> ---------------------------------------------------
>
>                 Key: FLINK-3234
>                 URL: https://issues.apache.org/jira/browse/FLINK-3234
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataSet API
>    Affects Versions: 1.0.0, 0.10.1
>            Reporter: Fabian Hueske
>            Assignee: Chiwan Park
>             Fix For: 1.0.0
>
>
> The following is not supported by the DataSet API:
> {code}
> DataSet<MyObject> data = ...
> DataSet<MyObject> data.sortPartition(
>   new KeySelector<MyObject, Long>() {
>     public Long getKey(MyObject v) {
>       ...
>     }
>   }, 
>   Order.ASCENDING);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to