azagrebin commented on a change in pull request #11245:
URL: https://github.com/apache/flink/pull/11245#discussion_r445404435
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -137,11 +139,17 @@
.withDescription("The cluster-id, which should be no more than
45 characters, is used for identifying " +
"a unique Flink cluster. If not set, the client will
automatically generate it with a random ID.");
+ // The default container image that ties to the exact needed versions
of both Flink and Scala.
+ public static final String DEFAULT_CONTAINER_IMAGE = "flink:" +
EnvironmentInformation.getVersion() + "-scala_" +
EnvironmentInformation.getScalaVersion();
+
+ @Documentation.OverrideDefault("The default value depends on the
actually running version. In general it looks like
\"flink_<FLINK_VERSION>-scala_<SCALA_VERSION>\"")
Review comment:
```suggestion
@Documentation.OverrideDefault("The default value depends on the
actually running version. In general it looks like
\"flink:<FLINK_VERSION>-scala_<SCALA_VERSION>\"")
```
##########
File path: docs/ops/deployment/kubernetes.md
##########
@@ -262,7 +262,7 @@ spec:
spec:
containers:
- name: jobmanager
- image: flink:{% if site.is_stable
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest{% endif %}
+ image: flink:{% if site.is_stable
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest # The
'latest' tag contains the latest released version of Flink for a specific Scala
version which will mismatch with your application over time.{% endif %}
Review comment:
How about this:
```
flink:latest # The 'latest' tag contains the latest released version of
Flink for a specific Scala version which can conflict with the versions, used
by your application.
```
Somehow this sounds confusing:
`which will mismatch with your application over time`, in particular `over
time`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
