senegalo commented on a change in pull request #12056:
URL: https://github.com/apache/flink/pull/12056#discussion_r446633295
##########
File path:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java
##########
@@ -77,6 +78,7 @@
private final RMQConnectionConfig rmqConnectionConfig;
protected final String queueName;
private final boolean usesCorrelationId;
+ protected RMQDeserializationSchema<OUT> deliveryDeserializer;
protected DeserializationSchema<OUT> schema;
Review comment:
just a curious question "i am not that good with Java tbh !
Why a static function here ? why not a private method since it will only be
used from within the class ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
