becketqin commented on a change in pull request #12566:
URL: https://github.com/apache/flink/pull/12566#discussion_r447402523
##########
File path:
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/synchronization/FutureCompletingBlockingQueueTest.java
##########
@@ -0,0 +1,22 @@
+package org.apache.flink.connector.base.source.reader.synchronization;
+
+import org.junit.Test;
+
+import static org.junit.Assert.*;
+
+/**
+ * The unit test for {@link FutureCompletingBlockingQueue}
+ */
+public class FutureCompletingBlockingQueueTest {
+
+ private static final Integer DEFAULT_CAPACITY = 10000;
Review comment:
Should the unit test use a value different from the default value?
##########
File path:
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/synchronization/FutureCompletingBlockingQueueTest.java
##########
@@ -0,0 +1,22 @@
+package org.apache.flink.connector.base.source.reader.synchronization;
+
+import org.junit.Test;
+
+import static org.junit.Assert.*;
Review comment:
Can you add a license header to the file? Also, we usually do not use
`*` in the imports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
