JingsongLi commented on a change in pull request #12803:
URL: https://github.com/apache/flink/pull/12803#discussion_r448739867
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkChangelogModeInferenceProgram.scala
##########
@@ -687,9 +701,24 @@ class FlinkChangelogModeInferenceProgram extends
FlinkOptimizeProgram[StreamOpti
private def visitSink(
sink: StreamPhysicalRel,
sinkRequiredTraits: Seq[UpdateKindTrait]): Option[StreamPhysicalRel] =
{
- val children = sinkRequiredTraits.flatMap(t => visitChildren(sink, t))
+ var throwable: Throwable = null
+ val children = sinkRequiredTraits.flatMap { t =>
+ try {
+ visitChildren(sink, t)
Review comment:
Can we change the return type of `visitChildren`? Instead of catch
exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
