JingsongLi commented on a change in pull request #12803:
URL: https://github.com/apache/flink/pull/12803#discussion_r448811265
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkChangelogModeInferenceProgram.scala
##########
@@ -618,12 +616,10 @@ class FlinkChangelogModeInferenceProgram extends
FlinkOptimizeProgram[StreamOpti
return None
case Some(newChild) =>
val providedTrait =
newChild.getTraitSet.getTrait(UpdateKindTraitDef.INSTANCE)
- val childDescription = newChild.getRelDetailedDescription
if (!providedTrait.satisfies(requiredChildrenTrait)) {
- throw new TableException(s"Provided trait $providedTrait can't
satisfy " +
- s"required trait $requiredChildrenTrait. " +
- s"This is a bug in planner, please file an issue. \n" +
- s"Current node is $childDescription")
+ // the provided trait can't satisfy required trait, thus we
should return None.
+ // for example, the changelog source can't provide
ONLY_UPDATE_AFTER.
+ None
Review comment:
`return None`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
