godfreyhe commented on a change in pull request #11321:
URL: https://github.com/apache/flink/pull/11321#discussion_r449549939
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/utils/factories/CalculatedTableFactory.java
##########
@@ -105,9 +106,16 @@ private CalculatedQueryOperation createFunctionCall(
.map(FunctionIdentifier::asSummaryString)
.orElse(functionDefinition.toString()));
+ String name;
+ if (functionDefinition instanceof
TableFunctionDefinition) {
+ name = ((TableFunctionDefinition)
functionDefinition).getName();
+ } else {
+ throw new ValidationException("Unsupported
FunctionDefinition: " + functionDefinition.getKind());
Review comment:
Because this utility class is only used for creating a
`CalculatedQueryOperation` from a `TableFunction`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
