godfreyhe commented on a change in pull request #11321:
URL: https://github.com/apache/flink/pull/11321#discussion_r449564056
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/expressions/converter/LegacyScalarFunctionConvertRule.java
##########
@@ -42,11 +42,10 @@
FunctionDefinition def = call.getFunctionDefinition();
if (def instanceof ScalarFunctionDefinition) {
ScalarFunction scalaFunc = ((ScalarFunctionDefinition)
def).getScalarFunction();
- FunctionIdentifier identifier =
call.getFunctionIdentifier()
-
.orElse(FunctionIdentifier.of(scalaFunc.functionIdentifier()));
+ FunctionIdentifier identifier =
FunctionIdentifier.of(((ScalarFunctionDefinition) def).getName());
SqlFunction sqlFunction =
UserDefinedFunctionUtils.createScalarSqlFunction(
identifier,
- scalaFunc.toString(),
+ identifier.toString(),
Review comment:
we can revert this, and change the implementation of
`ScalarSqlFunction#toString()` method which return value will be used for
`explainTerms` method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
