Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1588#issuecomment-180753150
  
    I didn't test this myself, but this diff could be sufficient for testing 
your change:
    
    ```diff
    diff --git 
a/flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
 
b/flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
    index 8c9a9c7..999b5be 100644
    --- 
a/flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
    +++ 
b/flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
    @@ -180,6 +180,7 @@ public class YARNSessionFIFOITCase extends YarnTestBase 
{
                                    "-n", "1",
                                    "-jm", "768",
                                    "-tm", "1024",
    +                               "-s", "3", // set the slots 3 to check if 
the vCores are set properly!
                                    "-nm", "customName",
                                    "-Dfancy-configuration-value=veryFancy",
                                    "-Dyarn.maximum-failed-containers=3"},
    @@ -268,6 +269,7 @@ public class YARNSessionFIFOITCase extends YarnTestBase 
{
                                    String command = Joiner.on(" 
").join(entry.getValue().getLaunchContext().getCommands());
                                    
if(command.contains(YarnTaskManagerRunner.class.getSimpleName())) {
                                            taskManagerContainer = 
entry.getKey();
    +                                       
Assert.assertEquals(3,entry.getValue().getResource().getVirtualCores());
                                            nodeManager = nm;
                                            nmIdent = new 
NMTokenIdentifier(taskManagerContainer.getApplicationAttemptId(), null, "",0);
                                            // allow myself to do stuff with 
the container
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to