[ 
https://issues.apache.org/jira/browse/FLINK-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163318#comment-17163318
 ] 

Andrey Zagrebin edited comment on FLINK-15649 at 7/23/20, 8:19 AM:
-------------------------------------------------------------------

I agree that mounting volumes is very useful to do even basic customisation of 
Flink and its application. We also use mounting volumes a lot for documented 
examples of how to use standalone container deployment (non-native k8s).

I briefly looked into the PR. It looks like we are re-implementing there 
specification of all types of mounted volumes. It is a lot of code (already 850 
new lines) to maintain and potentially extend with other volumes, possibly 
introduced in future.

Therefore, I am also wondering whether we should actually firstly try to 
introduce the pod template which enables even more customisation as I 
understand. If we just document examples of how to write the basic templates 
for basic customisation (e.g. volumes), this can already solve a lot. The pod 
template looks universal and less to maintain.

[~fly_in_gis] [~felixzheng] As I understand the pod template design is in 
progress. Are there fundamental concerns or blockers for the pod template in 
1.12? Something with init containers?


was (Author: azagrebin):
I agree that mounting volumes is very useful to do even basic customisation of 
Flink and its application. We also use mounting volumes a lot for documented 
examples of how to use standalone container deployment (non-native k8s).

I briefly looked into the PR. It looks like we are re-implementing there 
specification of all types of mounted volumes. It is a lot of code (already 850 
new lines) to maintain and potentially extend with other volumes, possibly 
introduced in future.

Therefore, I am also wondering whether we should actually firstly try to 
introduce the pod template which enables even more customisation as I 
understand. If we just document examples of how to write the basic templates 
for basic customisation (e.g. volumes), this can already solve a lot. The pod 
template sounds universal and less to maintain.

[~fly_in_gis] [~felixzheng] As I understand the pod template design is in 
progress. Are there fundamental concerns or blockers for the pod template in 
1.12? Something with init containers?

> Support mounting volumes 
> -------------------------
>
>                 Key: FLINK-15649
>                 URL: https://issues.apache.org/jira/browse/FLINK-15649
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Deployment / Kubernetes
>            Reporter: Canbin Zheng
>            Priority: Major
>              Labels: pull-request-available
>
> Add support for mounting K8S volumes, including emptydir, hostpath, pv etc.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to