[
https://issues.apache.org/jira/browse/FLINK-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163400#comment-17163400
]
Canbin Zheng edited comment on FLINK-15649 at 7/23/20, 10:14 AM:
-----------------------------------------------------------------
Hi [~azagrebin]
{quote}I briefly looked into the PR. It looks like we are re-implementing there
specification of all types of mounted volumes. It is a lot of code (already 850
new lines) to maintain and potentially extend with other volumes, possibly
introduced in future.
{quote}
True, maintenance could be a problem in the long run.
{quote}Therefore, I am also wondering whether we should actually firstly try to
introduce the pod template which enables even more customisation as I
understand. If we just document examples of how to write the basic templates
for basic customisation (e.g. volumes), this can already solve a lot. The pod
template looks universal and less to maintain.
{quote}
I agree with the routine to first introduce the pod template, it saves our
efforts to introduce lots of K8s-side advanced features, such as DNS
configuration, pod affinity/anti-affinity.
{quote}As I understand the pod template design is in progress. Are there
fundamental concerns or blockers for the pod template in 1.12? Something with
init containers?
{quote}
Yes, I am working on, currently, there are no blocker issues for this feature
in 1.12.
was (Author: felixzheng):
Hi [~azagrebin]
??I briefly looked into the PR. It looks like we are re-implementing there
specification of all types of mounted volumes. It is a lot of code (already 850
new lines) to maintain and potentially extend with other volumes, possibly
introduced in future.??
True, maintenance could be a problem in the long run.
??Therefore, I am also wondering whether we should actually firstly try to
introduce the pod template which enables even more customisation as I
understand. If we just document examples of how to write the basic templates
for basic customisation (e.g. volumes), this can already solve a lot. The pod
template looks universal and less to maintain.??
I agree with the routine to first introduce the pod template, it saves our
efforts to introduce lots of K8s-side advanced features, such as DNS
configuration, pod affinity/anti-affinity.
??As I understand the pod template design is in progress. Are there fundamental
concerns or blockers for the pod template in 1.12? Something with init
containers???
Yes, I am working on, currently, there are no blocker issues for this feature
in 1.12.
> Support mounting volumes
> -------------------------
>
> Key: FLINK-15649
> URL: https://issues.apache.org/jira/browse/FLINK-15649
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
> Reporter: Canbin Zheng
> Priority: Major
> Labels: pull-request-available
>
> Add support for mounting K8S volumes, including emptydir, hostpath, pv etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
