rmetzger commented on a change in pull request #35:
URL: https://github.com/apache/flink-docker/pull/35#discussion_r462999016
##########
File path: generate-stackbrew-library.sh
##########
@@ -47,7 +47,7 @@ pruneTags() {
else
# remove "latest" and any "scala_" tag, unless it is the latest version
# the "scala_" tag has a similar semantic as the "latest" tag in
docker registries.
- echo $tags | sed -E 's|, (scala\|latest)[-_[:alnum:]]*||g'
+ echo $tags | sed -E 's|, (scala\|latest)[-_.[:alnum:]]*||g'
Review comment:
Otherwise, the tags look like this `Tags: 1.10.1-scala_2.11,
1.10-scala_2.11.11`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
