DG-Wangtao commented on a change in pull request #13045:
URL: https://github.com/apache/flink/pull/13045#discussion_r464240384
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointRequestDeciderTest.java
##########
@@ -119,13 +119,13 @@ public void testQueueSizeLimitPriority() {
public void testSavepointTiming() {
testTiming(regularSavepoint(), TriggerExpectation.IMMEDIATELY);
testTiming(periodicSavepoint(), TriggerExpectation.IMMEDIATELY);
- testTiming(nonForcedSavepoint(),
TriggerExpectation.AFTER_PAUSE);
+ testTiming(nonForcedSavepoint(),
TriggerExpectation.IMMEDIATELY);
Review comment:
Yes, @klion26 , maybe we need this.
There are two functions called `testUserSubmittedPrioritized` and
`testSavepointPrioritized` in `CheckpointRequestDeciderTest` for testing the
ordering of requests', forced savepoint and checkpoints, and I will write two
other test functions for testing the order of unforced savepoints' and
checkpoints' requests , using `testRequestsOrdering` too.
What do you think about this, @klion26
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
