xintongsong commented on a change in pull request #13004:
URL: https://github.com/apache/flink/pull/13004#discussion_r469080145
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -1064,6 +1076,13 @@ public void handleError(final Exception exception) {
*/
protected abstract void initialize() throws ResourceManagerException;
+ /**
+ * Terminates the framework specific components.
+ *
+ * @throws Throwable with occurs during termination.
+ */
+ protected abstract void terminate() throws Throwable;
Review comment:
I kept it `Throwable` because this was what
`KubernetesResourceManager#onStop` and `YarnResourceManager#onStop` catch.
Weaken to throwing `Exception` also makes sense to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
