zentol commented on a change in pull request #13125: URL: https://github.com/apache/flink/pull/13125#discussion_r469190780
########## File path: tools/azure-pipelines/build-nightly-dist.yml ########## @@ -0,0 +1,103 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +jobs: + - job: ${{parameters.stage_name}}_binary + pool: + vmImage: 'ubuntu-16.04' + container: flink-build-container + workspace: + clean: all + steps: + - task: Cache@2 + inputs: + key: $(CACHE_KEY) + restoreKeys: $(CACHE_FALLBACK_KEY) + path: $(MAVEN_CACHE_FOLDER) + displayName: Cache Maven local repo + continueOnError: true + # Create binary release + - script: | + source ./tools/ci/maven-utils.sh + setup_maven + run_mvn -version + export MVN="run_mvn" + + export RELEASE_VERSION=$(MVN_RUN_VERBOSE=false run_mvn --file pom.xml org.apache.maven.plugins:maven-help-plugin:3.1.0:evaluate -Dexpression=project.version -q -DforceStdout) + echo "Determined RELEASE_VERSION as '$RELEASE_VERSION' " + cd tools + MVN_RUN_VERBOSE=true SKIP_GPG=true ./releasing/create_binary_release.sh + echo "Created files:" + find ./releasing/release + displayName: Build nightly + # deploy binary release + - task: PublishPipelineArtifact@1 + displayName: Upload nightly Review comment: ```suggestion - task: PublishPipelineArtifact@1 displayName: Upload snapshot binary release ``` ########## File path: tools/azure-pipelines/build-nightly-dist.yml ########## @@ -0,0 +1,103 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +jobs: + - job: ${{parameters.stage_name}}_binary + pool: + vmImage: 'ubuntu-16.04' + container: flink-build-container + workspace: + clean: all + steps: + - task: Cache@2 + inputs: + key: $(CACHE_KEY) + restoreKeys: $(CACHE_FALLBACK_KEY) + path: $(MAVEN_CACHE_FOLDER) + displayName: Cache Maven local repo + continueOnError: true + # Create binary release + - script: | + source ./tools/ci/maven-utils.sh + setup_maven + run_mvn -version + export MVN="run_mvn" + + export RELEASE_VERSION=$(MVN_RUN_VERBOSE=false run_mvn --file pom.xml org.apache.maven.plugins:maven-help-plugin:3.1.0:evaluate -Dexpression=project.version -q -DforceStdout) + echo "Determined RELEASE_VERSION as '$RELEASE_VERSION' " + cd tools + MVN_RUN_VERBOSE=true SKIP_GPG=true ./releasing/create_binary_release.sh + echo "Created files:" + find ./releasing/release + displayName: Build nightly + # deploy binary release + - task: PublishPipelineArtifact@1 + displayName: Upload nightly + inputs: + targetPath: ./tools/releasing/release + artifact: nightly-release + - job: ${{parameters.stage_name}}_maven + pool: + vmImage: 'ubuntu-16.04' + container: flink-build-container + timeoutInMinutes: 100 # 40 minutes per scala version + 20 buffer + workspace: + clean: all + steps: + - task: Cache@2 + inputs: + key: $(CACHE_KEY) + restoreKeys: $(CACHE_FALLBACK_KEY) + path: $(MAVEN_CACHE_FOLDER) + displayName: Cache Maven local repo + continueOnError: true + # Upload snapshot + - script: | + source ./tools/ci/maven-utils.sh + setup_maven + run_mvn -version + + cd tools + cat << EOF > deploy-settings.xml + <settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 + https://maven.apache.org/xsd/settings-1.0.0.xsd";> + <servers> + <server> + <id>apache.snapshots.https</id> + <username>${MAVEN_DEPLOY_USER}</username> + <password>${MAVEN_DEPLOY_PASS}</password> + </server> + </servers> + <mirrors> + <mirror> + <id>google-maven-central</id> Review comment: what is this mirror for? If it does what I think it is (mirroring the artifacts to maven central where they are publicly accessible to all users), then it should be removed. ########## File path: tools/azure-pipelines/build-apache-repo.yml ########## @@ -74,6 +74,11 @@ stages: dependsOn: [] # depending on an empty array makes the stages run in parallel condition: or(eq(variables['Build.Reason'], 'Schedule'), eq(variables['MODE'], 'nightly')) jobs: + - template: build-nightly-dist.yml + parameters: + stage_name: cron_nightly_dist Review comment: ```suggestion stage_name: cron_snapshot_deployment ``` ########## File path: tools/azure-pipelines/build-nightly-dist.yml ########## @@ -0,0 +1,103 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +jobs: + - job: ${{parameters.stage_name}}_binary + pool: + vmImage: 'ubuntu-16.04' + container: flink-build-container + workspace: + clean: all + steps: + - task: Cache@2 + inputs: + key: $(CACHE_KEY) + restoreKeys: $(CACHE_FALLBACK_KEY) + path: $(MAVEN_CACHE_FOLDER) + displayName: Cache Maven local repo + continueOnError: true + # Create binary release + - script: | + source ./tools/ci/maven-utils.sh + setup_maven + run_mvn -version + export MVN="run_mvn" + + export RELEASE_VERSION=$(MVN_RUN_VERBOSE=false run_mvn --file pom.xml org.apache.maven.plugins:maven-help-plugin:3.1.0:evaluate -Dexpression=project.version -q -DforceStdout) Review comment: ```suggestion export RELEASE_VERSION=$(MVN_RUN_VERBOSE=false run_mvn help:evaluate -Dexpression=project.version -q -DforceStdout) ``` ########## File path: tools/azure-pipelines/build-nightly-dist.yml ########## @@ -0,0 +1,103 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +jobs: + - job: ${{parameters.stage_name}}_binary + pool: + vmImage: 'ubuntu-16.04' + container: flink-build-container + workspace: + clean: all + steps: + - task: Cache@2 + inputs: + key: $(CACHE_KEY) + restoreKeys: $(CACHE_FALLBACK_KEY) + path: $(MAVEN_CACHE_FOLDER) + displayName: Cache Maven local repo + continueOnError: true + # Create binary release + - script: | Review comment: is it a hard requirement that the script is the first item? If not, then having the displayName as the first item would eliminate the requirement of needing a comment to explain what it does. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
