[
https://issues.apache.org/jira/browse/FLINK-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhu Zhu closed FLINK-18355.
---------------------------
Resolution: Fixed
Done via
2f12d9c78bc0991770df977c88f6cdecf3e6c33d
36366959e96cfbaa2f227db5cfeca76e7f990138
8cf4ddef93921e450565b5af3818d4f295c74edc
8593489cefdf064a7cbdf8f0f810361a9834810a
> Simplify tests of SlotPoolImpl
> ------------------------------
>
> Key: FLINK-18355
> URL: https://issues.apache.org/jira/browse/FLINK-18355
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Coordination, Tests
> Reporter: Zhu Zhu
> Assignee: Zhilong Hong
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.0
>
> Time Spent: 336h
> Remaining Estimate: 0h
>
> Tests of SlotPoolImpl, including SlotPoolImplTest, SlotPoolInteractionsTest
> and SlotPoolSlotSharingTest, are somehow unnecessarily complicated in the
> code involvement. E.g. SchedulerImp built on top of SlotPoolImpl is used to
> allocate slots from SlotPoolImpl, which can be simplified by directly invoke
> slot allocation on SlotPoolImpl.
> Besides that, there are quite some duplications between tests classes of
> SlotPoolImpl, this further includes SlotPoolPendingRequestFailureTest,
> SlotPoolRequestCompletionTest and SlotPoolBatchSlotRequestTest.
> It can ease future development and maintenance a lot if we clean up these
> tests by
> 1. introduce a comment test base for fields and methods reuse
> 2. remove the usages of SchedulerImp for slotpool testing
> 3. other possible simplifications
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
