[ 
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142691#comment-15142691
 ] 

ASF GitHub Bot commented on FLINK-2111:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r52598649
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
 ---
    @@ -464,6 +464,33 @@ class JobManager(
               )
           }
     
    +    case StopJob(jobID) =>
    +      log.info(s"Trying to stop job with ID $jobID.")
    +
    +      currentJobs.get(jobID) match {
    +        case Some((executionGraph, _)) =>
    +          try {
    +            if (!executionGraph.isStoppable()) {
    +              sender ! StoppingFailure(jobID, new 
IllegalStateException(s"Job with ID $jobID" +
    +                " is not stoppable."))
    +            } else if(executionGraph.getState() != JobStatus.CREATED
    +                && executionGraph.getState() != JobStatus.RUNNING
    +                && executionGraph.getState() != JobStatus.RESTARTING) {
    +              sender ! StoppingFailure(jobID, new 
IllegalStateException(s"Job with ID $jobID" +
    --- End diff --
    
    `decorateMessage` is missing


> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
>                 Key: FLINK-2111
>                 URL: https://issues.apache.org/jira/browse/FLINK-2111
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Runtime, JobManager, Local Runtime, 
> Streaming, TaskManager, Webfrontend
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is 
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks 
> such that the sources can stop emitting data and shutdown cleanly, resulting 
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for 
> https://issues.apache.org/jira/browse/FLINK-1929



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to