[
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142704#comment-15142704
]
ASF GitHub Bot commented on FLINK-2111:
---------------------------------------
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-182859453
Really good work @mjsax.
I had a couple of minor inline comments with respect to the latest commit
and some with respect to the overall changes (especially concerning the
`decorateMessage` method).
Why have you changed the `vendor.js` and the `index.js` file? I thought
that these files should stay unchanged.
I was wondering whether we shouldn't make the `StoppableSourceStreamTask`
and the `StoppableStreamSource` type safe, e.g. enforcing that the
`StreamSource` and the `SourceFunction` are actually stoppable. Currently, this
is not properly checked/enforced. This should be done by the compiler.
> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
> Key: FLINK-2111
> URL: https://issues.apache.org/jira/browse/FLINK-2111
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime, JobManager, Local Runtime,
> Streaming, TaskManager, Webfrontend
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks
> such that the sources can stop emitting data and shutdown cleanly, resulting
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for
> https://issues.apache.org/jira/browse/FLINK-1929
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
