curcur commented on a change in pull request #13175: URL: https://github.com/apache/flink/pull/13175#discussion_r473929844
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java ########## @@ -320,6 +320,12 @@ void setDiscardCallback(@Nullable CompletedCheckpointStats.DiscardCallback disca @Override public String toString() { - return String.format("Checkpoint %d @ %d for %s", checkpointID, timestamp, job); + return String.format( + "%s %d @ %d for %s located at %s", + props.getCheckpointType(), Review comment: I do not have a strong opinion on this as well. But since you ask, let me have a try LOL :-) The only concern is that we "might" have more types in the future 1. checkpoint or savepoint; 2. Synchronous or not; 3. Global or Individual; 4. unaligned or not (I mean it could be); - It is a bit difficult to categorize the enum of CheckpointType to just "Checkpoint" and "Savepoint" - It is also difficult to tell what level of technicality a user needs. For a user that makes an SYNC_SAVEPOINT, he/she probably has enough knowledge to understand what an SYNC_SAVEPOINT is. Or in other words, if we think SYNC_SAVEPOINT is not that understandable, we probably need to improve its expressiveness. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org