AHeise commented on a change in pull request #13175:
URL: https://github.com/apache/flink/pull/13175#discussion_r474154852
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
##########
@@ -320,6 +320,12 @@ void setDiscardCallback(@Nullable
CompletedCheckpointStats.DiscardCallback disca
@Override
public String toString() {
- return String.format("Checkpoint %d @ %d for %s", checkpointID,
timestamp, job);
+ return String.format(
+ "%s %d @ %d for %s located at %s",
+ props.getCheckpointType(),
Review comment:
I guess having a bit technicality in the log should be okay.
Another easy fix would be to override the `toString` in the checkpoint type
and output it in more readable form.
"Checkpoint"
"Savepoint"
"Savepoint (sync)"
I also don't know if SYNC_SAVEPOINT would appear in materialized checkpoint
at all - might be also some transient information that gets replaced by
SAVEPOINT on recovery?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
