Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52739054
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala
---
@@ -150,7 +151,11 @@ object CodeGenUtils {
sealed abstract class FieldAccessor
- case class ObjectFieldAccessor(fieldName: String) extends FieldAccessor
+ case class ObjectFieldAccessor(field: Field) extends FieldAccessor
+
+ case class ObjectGenericFieldAccessor(name: String) extends FieldAccessor
+
+ case class ObjectPrivateFieldAccessor(field: Field) extends FieldAccessor
--- End diff --
I think we do not have to separate the cases of public and private fields
and make the fields always accessible.
This would reduce a bit of code complexity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
