Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1624#discussion_r52739359
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
 ---
    @@ -42,13 +42,30 @@ import scala.collection.mutable
       * @param config configuration that determines runtime behavior
       * @param input1 type information about the first input of the Function
       * @param input2 type information about the second input if the Function 
is binary
    +  * @param inputPojoFieldMapping additional mapping information if input1 
is a POJO (POJO types
    +  *                              have no deterministic field order). We 
assume that input2 is
    +  *                              converted before and thus is never a POJO.
       */
     class CodeGenerator(
    -    config: TableConfig,
    -    input1: TypeInformation[Any],
    -    input2: Option[TypeInformation[Any]] = None)
    +   config: TableConfig,
    +   input1: TypeInformation[Any],
    +   input2: Option[TypeInformation[Any]] = None,
    +   inputPojoFieldMapping: Array[Int] = Array())
    --- End diff --
    
    Make this parameter optional?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to