SteNicholas opened a new pull request #13298:
URL: https://github.com/apache/flink/pull/13298


   ## What is the purpose of the change
   
   *Method `validateAndGetChildSort` of `SortOperationFactory` checks the fetch 
of `previousSort`, which doesn't support continuously fetch or limit. Indeed in 
SQL perspective, Flink SQL supports continuously fetch or limit, therefore the 
`fetch` and `limit` Table API also needs to support this case. 
`validateAndGetChildSort` should remove the check of `previousSort` fetch.*
   
   ## Brief change log
   
     - *Method `validateAndGetChildSort` and `createLimitWithOffset` remove the 
check of `previousSort` fetch.*
   
   ## Verifying this change
   
     - *Method `testFetch` and `testOffsetAndFetch` of `LegacyLimitITCase` add 
test cases for continuously fetch or limit.*
     - *Method `testOrderByFetch` of `SortITCase ` add test cases for 
continuously fetch.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to