[
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147205#comment-15147205
]
ASF GitHub Bot commented on FLINK-2111:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-184165224
This looks pretty good by now. I have a few remaining comments, otherwise
this looks good to go:
1. There is a duplicate and incorrect test dependency in `flink-tests`
(critical, will break the build later)
2. The are two types of Exceptions:
- ProgramStopException
- StoppingException
Both simply extend `Exception`. Can we consolidate these into one
class?
3. The JobManager tries to stop the job in state `CREATED`, `RUNNING`,
and `RESTARTING`. Are we sure that the states `CREATED` and `RESTARTING` behave
well?
4. Minor comment: Adding the generic `SRC` parameter to the
`SourceStreamTask` looks like a bit of overkill for only adding the
`StoppableFunction` interface to the generic function type. A simple cast in
`StoppableSourceStreamTask.stop()` would probably be the more lightweight
change.
> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
> Key: FLINK-2111
> URL: https://issues.apache.org/jira/browse/FLINK-2111
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime, JobManager, Local Runtime,
> Streaming, TaskManager, Webfrontend
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks
> such that the sources can stop emitting data and shutdown cleanly, resulting
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for
> https://issues.apache.org/jira/browse/FLINK-1929
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
