[
https://issues.apache.org/jira/browse/FLINK-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148337#comment-15148337
]
ASF GitHub Bot commented on FLINK-3396:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1633#discussion_r52986635
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1073,57 +1073,73 @@ class JobManager(
// execute the recovery/writing the jobGraph into the
SubmittedJobGraphStore asynchronously
// because it is a blocking operation
future {
- try {
- if (isRecovery) {
- executionGraph.restoreLatestCheckpointedState()
- }
- else {
- val snapshotSettings = jobGraph.getSnapshotSettings
- if (snapshotSettings != null) {
- val savepointPath = snapshotSettings.getSavepointPath()
+ val restoreStateSuccess =
+ try {
+ if (isRecovery) {
+ executionGraph.restoreLatestCheckpointedState()
--- End diff --
Yes, it had the same issue as the savepoint restore. If restoring the
checkpoint failed, job submission was never ACK'd, but execution was restarted
etc. I'm not sure that this is the behaviour we want in the long term, but I
think failing the submission is clearer behaviour right now.
Another issue I've noticed is the following: when HA checkpoint recovery
fails and the job cannot be scheduled for execution, the job will eventually be
removed from ZooKeeper and hence never be recovered again. Let me open an issue
for this...
> Job submission Savepoint restore logic flawed
> ---------------------------------------------
>
> Key: FLINK-3396
> URL: https://issues.apache.org/jira/browse/FLINK-3396
> Project: Flink
> Issue Type: Bug
> Reporter: Ufuk Celebi
> Assignee: Ufuk Celebi
> Fix For: 1.0.0
>
>
> When savepoint restoring fails, the thrown Exception fails the execution
> graph, but the client is not informed about the failure.
> The expected behaviour is that the submission should be acked with success or
> failure in any case. With savepoint restore failures, the ack message will be
> skipped.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
