[ 
https://issues.apache.org/jira/browse/FLINK-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148700#comment-15148700
 ] 

ASF GitHub Bot commented on FLINK-3396:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1633#discussion_r53019879
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
 ---
    @@ -1079,6 +1079,9 @@ class JobManager(
               executionGraph.registerExecutionListener(gateway)
               executionGraph.registerJobStatusListener(gateway)
             }
    +
    +        // All good. Submission succeeded!
    +        jobInfo.client ! 
decorateMessage(JobSubmitSuccess(jobGraph.getJobID))
    --- End diff --
    
    Oh boy... not my day today. Thanks for catching that. This was not expected.


> Job submission Savepoint restore logic flawed
> ---------------------------------------------
>
>                 Key: FLINK-3396
>                 URL: https://issues.apache.org/jira/browse/FLINK-3396
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>             Fix For: 1.0.0
>
>
> When savepoint restoring fails, the thrown Exception fails the execution 
> graph, but the client is not informed about the failure.
> The expected behaviour is that the submission should be acked with success or 
> failure in any case. With savepoint restore failures, the ack message will be 
> skipped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to