wuchong commented on a change in pull request #13275:
URL: https://github.com/apache/flink/pull/13275#discussion_r485332171
##########
File path:
flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/source/AbstractTableInputFormat.java
##########
@@ -186,24 +193,22 @@ public void close() throws IOException {
if (resultScanner != null) {
resultScanner.close();
}
- } finally {
- resultScanner = null;
- }
- }
-
- @Override
- public void closeInputFormat() throws IOException {
- try {
if (table != null) {
table.close();
}
+ if (connection != null) {
+ connection.close();
+ }
} finally {
+ resultScanner = null;
table = null;
+ connection = null;
}
}
@Override
public TableInputSplit[] createInputSplits(final int minNumSplits)
throws IOException {
+ initTable();
Review comment:
This is never closed ?
##########
File path:
flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/source/TableInputSplit.java
##########
@@ -26,7 +26,7 @@
* references to row below refer to the key of the row.
*/
@Internal
-class TableInputSplit extends LocatableInputSplit {
+public class TableInputSplit extends LocatableInputSplit {
Review comment:
We don't need to declare it `public`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
