Github user danielblazevski commented on the pull request:
https://github.com/apache/flink/pull/1220#issuecomment-184853357
P.S. about rebasing, need to be careful, something went wrong the first
time around. I actually just started working on a new laptop, and started the
git repo "from scratch" as follows:
```
clone the master and FLINK-1745 branches of my fork of Flink
checkout FLINK-1745, commit and push to origin (origin = my fork)
```
I set upstream to `origin`, is that a mistake? Namely, when I push
locally to GitHub, I set `upstream` to `origin`, namely I ran:
```
git push --set-upstream origin FLINK-1745
```
`origin` is my fork. Should I re-do this by adding a new `remote` called
`apache` and run
```
git push --set-upstream apache FLINK-1745
```
and then run the git commands you mentioned to rebase? Want to be careful,
making a re-basing mistake can be a nightmare to fix :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
