zhuxiaoshang opened a new pull request #13414:
URL: https://github.com/apache/flink/pull/13414


   ## What is the purpose of the change
   
   When I create the HiveCatalog and Flink is not able to connect to the 
HiveMetastore, the statement can not be executed, but the catalog is still 
created. Subsequent attempts to query the tables result in a NPE.
   
   In CatalogManager.registerCatalog.
   Consider open is a relatively easy operation to fail, we should put catalog 
into catalog manager after its open.
   
   
   ## Brief change log
   
   - have a double check about hive metastore client is whether created 
successfully and fail fast if not.
   - put catalog into catalog manager when the catalog is opened successfully.
   
   
   ## Verifying this change
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not documented)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to